• TODO: ktichen sink counter latency #5051
• fix(rivetkit): use engine actor stop threshold for shutdown #5049
• DO NOT MERGE: serverless restart race condition #4997
• fix(rivetkit): exit pid1 after signal shutdown #5045
• fix(rivetkit-core): decrement active actor metrics #5044
• fix(envoy-client): dont abort drain after 20s #5043 👈 (View in Graphite)
• temp: patch wasm-pack to point to latest binary #5037
• fix(rivetkit): require engine ping for health #5022
• feat(rivetkit): add current actor metrics #5020
• feat(rivetkit): expose low-cardinality metrics routes #5019
• docs(serverless): document timeout tuning #5018
• feat(kitchen-sink): add load testing harness #5017
• fix(rivetkit): expose client actor metadata #5016
• fix(runtime): avoid bounded dispatch channel stalls #5015
• fix(sqlite): fence remote requests by generation #5014
• feat(rivetkit-core): expose metrics endpoint #5013
• WIP: counter latency monitor #5011
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

PR #5043 Review: fix(envoy-client): dont abort drain after 20s

Critical Issues

1. Undefined Variable Usage — BLOCKER

File: rivetkit-rust/packages/rivetkit-core/src/registry/mod.rs

The diff removes the SHUTDOWN_DRAIN_TIMEOUT constant but it appears to still be referenced downstream. Combined with an unused stop_threshold variable that was presumably meant to replace it, this looks like incomplete work that will fail to compile.

Fix required: Either use stop_threshold where SHUTDOWN_DRAIN_TIMEOUT was, or remove stop_threshold and the TODO comment if the dynamic approach isn't ready for this PR.

Verify with: cargo check -p rivetkit-core

2. Unused Variable

File: rivetkit-rust/packages/rivetkit-core/src/registry/mod.rs

stop_threshold is defined but never used in the timeout call. The TODO comment says "Read threshold from protocol metadata, fall back to 30 min" but the implementation doesn't follow through — the dynamic value is computed but then discarded.

Code Quality

3. Kitchen Sink Mode Module (mode.ts)

The new mode.ts module cleanly separates three deployment modes (serverful, serverless, serverless-local). Logic is clear and well-documented. The Docker base image change from node:22-slim to node:22-trixie-slim (Debian 13) is reasonable.

4. Config Changes (pegboard.rs)

Numeric literal style (5 * 60 * 1000 for time values) is more readable than raw underscored integers and matches existing patterns in the file.

Test Coverage

No tests are included for the drain timeout behavior change. Before merging:

• Confirm compilation succeeds end-to-end
• Test shutdown drain behavior with the corrected timeout
• Test all three kitchen sink modes

Summary

Status: Needs fixes before merge

Required:

1. Resolve the SHUTDOWN_DRAIN_TIMEOUT/stop_threshold inconsistency — either wire up the dynamic value or revert to a constant until the dynamic approach is ready
2. Confirm cargo check -p rivetkit-core passes

Nice to have:

• Add a test for shutdown drain with the new timeout logic
• Document where actor_stop_threshold comes from in the protocol metadata